Fixes #5522, bug in custom scale example #5533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the property has_inverse = True to the custom scale example so that if axhline is later called on this axis an error is not produced.
| @@ -103,7 +103,7 @@ class MercatorLatitudeTransform(mtransforms.Transform): | |||
| input_dims = 1 | |||
| output_dims = 1 | |||
| is_separable = True | |||
|
|
|||
| has_inverse = True | |||
There was a problem hiding this comment.
Just a PEP8 nitpick here: Insert a blank space before the method definition.
|
Other than the PEP8 failure, looks good to me. |
| @@ -138,6 +138,7 @@ class InvertedMercatorLatitudeTransform(mtransforms.Transform): | |||
| input_dims = 1 | |||
| output_dims = 1 | |||
| is_separable = True | |||
| has_inverse = True | |||
|
|
|||
There was a problem hiding this comment.
I've fixed this and the file appears clear upon running pep8. Is there something else I'm missing?
tacaswell
added a commit
that referenced
this pull request
Nov 20, 2015
Fixes #5522, bug in custom scale example
|
@jeffrey-hokanson Thanks! Congratulations on (what I think) is your first contribution to mpl! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the property has_inverse = True to the custom scale example so that if axhline is later called on this axis an error is not produced.