8000 Fix staletxt by tacaswell · Pull Request #5486 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Fix staletxt #5486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 28, 2015
Merged

Fix staletxt #5486

merged 2 commits into from
Dec 28, 2015

Conversation

tacaswell
Copy link
Member

I am on the fence about the second commit.

@tacaswell
FIX: ensure axes marked stale when added text
48c028c 
Slightly reduced duplicate code

The `_add_text` is private because this should be refactored out when we
move to a single draw tree in the Axes.

Closes matplotlib#5476
@tacaswell
MNT/FIX: add explicit stale=True in add_* methods
b69b2ee 
In the Axes.add_* methods explicitly set the axes as stale, because
there is a new child in the draw tree.  This was implicitly happening
for add_line (and may have been for others)
@tacaswell tacaswell added this to the Critical bugfix release (1.5.1) milestone Nov 16, 2015
@mdboom
Copy link
Member
mdboom commented Dec 15, 2015

Can you elaborate on why you are on the fence? It seems that if we add artists, it should be stale...

@tacaswell
Copy link
Member Author

Mostly touching a bunch of places outside of the reported bug on the 1.5.x branch.

If you have interactive mode on, are using a backend which does not have it's own event loop, and are not using IPython; every time you set stale to True you get a full re-draw so there is something to be said for triggering it no more than strictly needed. On the other hand, the cross section on the pain point there is very small.

efiring added a commit that referenced this pull request Dec 28, 2015
@efiring
Merge pull request #5486 from tacaswell/fix_staletxt
345a8f9 
Fix staletxt
@efiring efiring merged commit 345a8f9 into matplotlib:v1.5.x Dec 28, 2015
@tacaswell tacaswell deleted the fix_staletxt branch December 28, 2015 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.5.1
Development

Successfully merging this pull request may close these issues.
3 participants
@tacaswell @mdboom @efiring
0