8000 Fix Cairo memleak by QuLogic · Pull Request #5372 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]

Skip to content

Fix Cairo memleak #5372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2015
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix leak in PyImage_color_conv.
The input buffer is copied internally when PyByteArray_FromStringAndSize
is called, so it doesn't need to stay around.
  • Loading branch information
QuLogic committed Oct 31, 2015
commit 5545d21b7bc94cb8aea2ac7eaef29a44f24e7cf8
2 changes: 1 addition & 1 deletion src/_image_wrapper.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -177,8 +177,8 @@ static PyObject *PyImage_color_conv(PyImage *self, PyObject *args, PyObject *kwd
free(buff));

PyObject *result = PyByteArray_FromStringAndSize((const char *)buff, size);
free(buff);
if (result == NULL) {
free(buff);
return NULL;
}

Expand Down
0