8000 Fix some compiler warnings by mdboom · Pull Request #5285 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Fix some compiler warnings #5285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 22, 2015
Merged

Fix some compiler warnings #5285

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2a83c9f
Fix some compiler warnings
mdboom Oct 20, 2015
2f2d79f
Revert change. Didn't mean to modify extern
mdboom Oct 20, 2015
f1c9c07
More compiler warnings from gcc
mdboom Oct 20, 2015
43e2d0b
Don't need module_state struct at all
mdboom Oct 21, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix some compiler warnings
  • Loading branch information
@mdboom
mdboom committed Oct 20, 2015
commit 2a83c9fee40571e92984da56de095e70a6b12a05
1 change: 0 additions & 1 deletion extern/qhull/global.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1843,7 +1843,6 @@ void qh_initqhull_start2(FILE *infile, FILE *outfile, FILE *errfile) {
time_t timedata;
int seed;

qh_CPUclock; /* start the clock(for qh_clock). One-shot. */
#if qh_QHpointer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't modify anything in extern/qhull as it is a verbatim copy of the qhull source code. I'd prefer to leave it as it is and accept compiler warnings rather than change it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this was only partly reverted the comment is missing

memset((char *)qh_qh, 0, sizeof(qhT)); /* every field is 0, FALSE, NULL */
#else
Expand Down
3 changes: 0 additions & 3 deletions lib/matplotlib/tri/_tri_wrapper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,10 +480,7 @@ extern "C" {

struct module_state
{
/* The Sun compiler can't handle empty structs */
#if defined(__SUNPRO_C) || defined(_MSC_VER)
int _dummy;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment referring to the module_state struct itself or the allocation that occurs at some other point? Because I don't see why this can't be remove entirely and just a straightforward 0 passed for the size.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point.

#endif
};

#if PY3K
Expand Down
3 changes: 0 additions & 3 deletions src/_contour_wrapper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,10 +140,7 @@ extern "C" {

struct module_state
{
/* The Sun compiler can't handle empty structs */
#if defined(__SUNPRO_C) || defined(_MSC_VER)
int _dummy;
#endif
};

#if PY3K
Expand Down
0