Fix tight layout in pyplot.py #4851
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o keep the frontend and the backend separate. This fixes issue 2654
…set_tight_layout was called
|
@mdehoon Do the tests pass locally for you? |
… figure.set_tight_layout was called" This reverts commit 9ee8cca.
|
This is all wrong -- tight_layout and set_tight_layout have different purposes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #2654.
In figure.py, there is a figure.set_tight_layout function (to be used by frontend code) and a figure.tight_layout function (called as part of figure.draw).
Calling figure.tight_layout directly breaks the separation between frontend and backend, causing issue #2654.
In pyplot.py, there is a function tight_layout which calls figure.tight_layout. The tight_layout function in pyplot.py is frontend code, and should call figure.set_tight_layout instead.
This pull request ensures that tight_layout in pyplot.py calls figure.set_tight_layout, and also fixes the example scripts where figure.tight_layout was called instead of figure.set_tight_layout.
We should consider renaming set_tight_layout in figure.py to tight_layout to be consistent with tight_layout in pyplot.py (this is currently not included in this pull request).