Remove trailing zeroes in path string output #4825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // Delete trailing zeros and decimal point | ||
| char *q = str; | ||
| for (; *q != 0; ++q) { |
There was a problem hiding this comment.
Are we guarranteed a null-terminated string?
There was a problem hiding this comment.
Yes. PyOS_double_to_string and PyOS_ascii_formatd return NULL-terminated strings. The docs don't actually say that, but since they don't return a length, I don't see how one could expect anything else.
|
Targeting to the right place then. |
|
Test failure is unrelated (latex related sillyness), merging. |
tacaswell
added a commit
that referenced
this pull request
Jul 30, 2015
PRF: Remove trailing zeroes in path string output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a performance problem introduced in 1f0e4a in that the path strings in SVG, PDF and PS include trailing zeroes in the numbers, making the file sizes significantly larger. This truncates any trailing zeroes or unnecessary decimal places.
I'm a little lost by which branch I should be making this against. It's a low-risk bugfix, so should go into whatever will end up in the most places.