MEP12 on set_and_get.py #4684
Merged
MEP12 on set_and_get.py #4684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,24 +1,24 @@ | |||
| """ | |||
|
|
|||
| MATLAB and pylab allow you to use setp and get to set and get | |||
| MATLAB and pyplot allow you to use setp and get to set and get | |||
There was a problem hiding this comment.
Let's go farther here: I don't think we need to refer to Matlab at all, and although "get" is an alias for "getp", I think it would be better to encourage use of the symmetric pair, setp and getp. These are indeed what is used in the example.
|
Nice improvements thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.