8000 MEP12 on transoffset.py by ericmjl · Pull Request #4639 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

MEP12 on transoffset.py #4639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jenshnielsen merged 3 commits into from
Jul 12, 2015
Merged

MEP12 on transoffset.py #4639

jenshnielsen merged 3 commits into from
Jul 12, 2015

Conversation

@ericmjl
Copy link
Contributor
@ericmjl ericmjl commented Jul 11, 2015

Changes:

  1. MEP12.
  2. PEP8 on syntax.

@ericmjl
MEP12 on transoffset.py
93f0f3b 
Changes:
1. MEP12.
2. PEP8 on syntax.
@jenshnielsen
Copy link
Member
jenshnielsen commented Jul 11, 2015

This is missing a blank line at the end

WeatherGod
WeatherGod reviewed Jul 12, 2015
View reviewed changes
examples/pylab_examples/transoffset.py Outdated
Copy link
Member
@WeatherGod WeatherGod Jul 12, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typical convention is to import this as mtrans

@jenshnielsen
Copy link
Member
jenshnielsen commented Jul 12, 2015

Looks like this is missing a numpy import

jenshnielsen added a commit that referenced this pull request Jul 12, 2015
@jenshnielsen
Merge pull request #4639 from ericmjl/mep12-transoffset.py
bf3095e 
MEP12 on transoffset.py
@jenshnielsen jenshnielsen merged commit bf3095e into matplotlib:master Jul 12, 2015
@ericmjl ericmjl deleted the mep12-transoffset.py branch July 12, 2015 15:28
@jenshnielsen jenshnielsen added the MEP: MEP12 gallery and examples improvements label Jul 12, 2015
@QuLogic QuLogic added this to the v1.5.0 milestone Nov 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

MEP: MEP12 gallery and examples improvements

Projects

None yet

Milestone

v1.5.0

Development

Successfully merging this pull request may close these issues.

5 participants

@ericmjl @jenshnielsen @WeatherGod @tacaswell @QuLogic
0