Keep alpha on marker edges. Fixes #4580 #4585
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this is quite right. I will try an alternative shortly. |
|
Fair enough, you have a better idea of what needs to change and what needs to stay the same. |
|
Replaced by #4586. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #4580.
GraphicsContextBaseallows for the foreground color (i.e. the marker line color) to get set independntly from the alpha of the fill colour, but callingset_alphaoverrides the already set colour with alpha.Here we add a keyword to decide whether we should set_alpha should do this or not.
Note, this behaviour may need tweaking to check if the "foreground color" has had an explicit alpha set or not. Or perhaps we go for a different behaviour altogether. Whatever we decide it shouldn't take too much tweaking to implement.