8000 STY: update with use of plt.subplots(), other readability edits by mscross · Pull Request #4361 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

STY: update with use of plt.subplots(), other readability edits #4361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2015
Merged

STY: update with use of plt.subplots(), other readability edits #4361

merged 1 commit into from
Apr 21, 2015

Conversation

mscross
Copy link
Contributor
@mscross mscross commented Apr 20, 2015
  • Edit example to interface via fig, ax0, ax1 rather than plt
  • Adjust vertical spacing between subplots to fix title, tick label overlap

image

  • Remove whitespace around some operators to improve readability

@tacaswell
Copy link
Member

This broke something in building the examples https://travis-ci.org/matplotlib/matplotlib/jobs/59272525

@jenshnielsen
Copy link
Member

ax0.title('pcolormesh with levels') etc should be ax0.set_title('pcolormesh with levels')

@jenshnielsen
Copy link
Member

In general I would prefer fig.tight_layout() over fig.subplots_adjust(hspace=0.35) when possible. Can you try that to see if it works as intended?

@mscross mscross force-pushed the examples_pcmlevels branch from c7e849c to eed437a Compare April 20, 2015 18:32
@mscross
Copy link
Contributor Author
mscross commented Apr 20, 2015

Fixed ax0.set_title() (same for ax1), used fig.tight_layout(), which gets the desired results.

Also fixed a branch issue that accidentally brought in commits from a previous unrelated PR (that broke the travis build).

tacaswell added a commit that referenced this pull request Apr 21, 2015
@tacaswell
Merge pull request #4361 from mscross/examples_pcmlevels
55f0fb3 
STY : update with example use of plt.subplots() and other readability edits

Cleaned up examples/images_contours_and_fields/pcolormesh_levels.py
@tacaswell tacaswell merged commit 55f0fb3 into matplotlib:master Apr 21, 2015
@tacaswell
Copy link
Member

@mscross Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mscross @tacaswell @jenshnielsen
0