8000 BUG : fix scaling issue with mlab.psd and odd NFFT by tacaswell · Pull Request #4326 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

BUG : fix scaling issue with mlab.psd and odd NFFT #4326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 12, 2015
Merged

BUG : fix scaling issue with mlab.psd and odd NFFT #4326

merged 2 commits into from
Apr 12, 2015

Conversation

tacaswell
Copy link
Member

closes #4324

This was referenced Apr 10, 2015
Closed
Merged
@tacaswell tacaswell added this to the Color overhaul milestone Apr 11, 2015
@jenshnielsen
Copy link
Member

Sensible. Should this have a test?

@tacaswell
Copy link
Member Author

We don't have any other tests on mlab...

On Sun, Apr 12, 2015, 05:55 Jens Hedegaard Nielsen notifications@github.com
wrote:

Sensible. Should this have a test?

—
Reply to this email directly or view it on GitHub
#4326 (comment)
.

jenshnielsen
jenshnielsen reviewed Apr 12, 2015
View reviewed changes
lib/matplotlib/mlab.py
# if we have a even number of frequencies, don't scale NFFT/2
if not NFFT % 2:
slc = slice(1, -1, None)
print(NFFT)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover print?

@jenshnielsen
Copy link
Member

Im not sure if we need a test for this but the tests in https://github.com/matplotlib/matplotlib/blob/master/lib/matplotlib/tests/test_mlab.py are for mlab?

@tacaswell
Copy link
Member Author

Ah, I would be wrong about the tests and yes, left over prints.

@tacaswell
Copy link
Member Author

@jenshnielsen Test added + prints nuked. Thanks for keeping me honest!

@jenshnielsen
Copy link
Member

Great. Will merge when Travis goes green

jenshnielsen added a commit that referenced this pull request Apr 12, 2015
@jenshnielsen
Merge pull request #4326 from tacaswell/fix_mlab_psd
063e3f1 
BUG : fix scaling issue with mlab.psd and odd NFFT
@jenshnielsen jenshnielsen merged commit 063e3f1 into matplotlib:color_overhaul Apr 12, 2015
@tacaswell tacaswell deleted the fix_mlab_psd branch May 16, 2015 03:25
@tacaswell tacaswell modified the milestones: Color overhaul, next major release (2.0) Oct 26, 2015
@QuLogic QuLogic modified the milestones: v1.5.0, 2.0 (style change major release) Oct 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tacaswell @jenshnielsen @QuLogic
0