Bug in ParseTuple for PyQuadContourGenerator_init #4229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense; but I wonder why it hasn't crashed on linux. I'm finding sizeof(bool) to be 1 both on OS X with clang++ and g++, and on linux with g++. |
|
Evidently the compilers on linux are more tolerant of my slack coding than on OS X. Perhaps there is a difference in bool alignment/packing; I don't have access to a mac so I can't check this. Anyway, the fix is good and is needed regardless of whether it fixes the original problem, so merging. |
ianthomas23
added a commit
that referenced
this pull request
Mar 16, 2015
Bug in ParseTuple for PyQuadContourGenerator_init
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for issue #4222. On compilers where
boolis not the same size asint, there is a stack overrun of the variadic functionPyArg_ParseTupleinPyQuadContourGenerator_init.