8000 Pull Request Suggestion for #4062 by beachdweller · Pull Request #4094 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Pull Request Suggestion for #4062 #4094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Pull Request Suggestion for #4062 #4094

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c731dab
started readme_4062.txt : described objective of the pull request and…
kangwonlee Feb 6, 2015
444bc5f
started test_4062.py : a test setup for FreeType check() and other re…
kangwonlee Feb 6, 2015
5a8275d
added analysis on FreeType check(), _check_for_pkg_config(), make_ext…
kangwonlee Feb 7, 2015
f7d4604
revised analysis : check_include_file(), has_include_file()
kangwonlee Feb 7, 2015
e532e97
added pprint();
kangwonlee Feb 7, 2015
b252e49
FreeType : added get_extension() method
kangwonlee Feb 7, 2015
b18df27
added possible freetype installation paths for mac osx
kangwonlee Feb 10, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
started readme_4062.txt : described objective of the pull request and… 
… early part of current status analysis
  • Loading branch information
@kangwonlee
kangwonlee committed Feb 10, 2015
commit c731dabdb73974278e392f8b4158b0bb6958919c
9 changes: 9 additions & 0 deletions readme_4062.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
The objective of this Pull Request is to make installation more robust on mac's regarding freetype paths
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is useful information, but should not go into the repo as a tracked file. This seems better suited as a commit message or comments in the code.


Analysis on existing commit(master 8f10470):
+ Setup.py has a list of pre-requisit packages "mpl_packages."
+ A for loop after "__main__" check goes through this list.
+ If package.check() returns a value other than None, setup recognizes that package.

+ Setupext.py has a class for Freetype incluidng check().
+ FreeType check() method searches for a header file name "ft2build.h."
0