8000 DOC: Organize colormap list and remove synonyms by endolith · Pull Request #3975 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

DOC: Organize colormap list and remove synonyms #3975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

DOC: Organize colormap list and remove synonyms #3975

wants to merge 1 commit into from

Conversation

endolith
Copy link
Contributor
@endolith endolith commented Jan 7, 2015

I did this in colormaps_reference.py but didn't notice there were more copies of the list in other files.

endolith@4279e56
endolith@3869065

@endolith
DOC: Organize colormap list and remove synonyms
3ecaa0b 
I did this in colormaps_reference.py but didn't notice there were more
copies of the list.

3869065
@endolith
Copy link
Contributor Author
endolith commented Jan 7, 2015

Oh wait, the files don't work now. Some numbers need to be adjusted or something. I will fix it some other time.

@tacaswell tacaswell added this to the unassigned milestone Jan 7, 2015
@tacaswell tacaswell closed this Feb 17, 2015
@tacaswell tacaswell mentioned this pull request Feb 17, 2015
Merged
@endolith
Copy link
Contributor Author
endolith commented Mar 8, 2015

Sorry for posting this and then disappearing. I've pushed the fix to lightness.py: endolith@5296ceb

I also have similar plots here comparing similar colormaps, by the way: https://secure.flickr.com/photos/56868697@N00/tags/luminance/ https://gist.github.com/endolith/2885984

@tacaswell
Copy link
Member

@endolith Is that commit in a PR someplace?

@endolith
Copy link
Contributor Author
endolith commented Mar 8, 2015

it's on this branch, but it was merged already, so isn't showing up here?

@tacaswell
Copy link
Member

You will probably have to make a new PR.

I bet gh stops tracking the source branch once it thinks it is
merged/closed which is probably a good thing so if you re-use a branch name
later old PRs don't go crazy.

On Sun, Mar 8, 2015 at 3:58 PM endolith notifications@github.com wrote:

it's on this branch, but it was merged already, so isn't showing up here?

—
Reply to this email directly or view it on GitHub
#3975 (comment)
.

@endolith endolith mentioned this pull request Mar 8, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@endolith @tacaswell
0