8000 Allow both linestyle definition "accents" and dash-patterns as linestyle by lennart0901 · Pull Request #3772 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Allow both linestyle definition "accents" and dash-patterns as linestyle #3772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 14, 2015
Merged

Allow both linestyle definition "accents" and dash-patterns as linestyle #3772

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
31b7b91
Allow both linestyle definition "accents" and dash-patterns as linest…
lennart0901 Jul 15, 2014
14fe5db
Make baseline image for testing single_dash pattern in collections.p…
lennart0901 Jul 29, 2014
8d1f0e0
Add new documentation for set_linestyle of patches, collection and li…
lennart0901 Nov 8, 2014
a18bad9
Rename ls_mapperr to ls_mapper_r and add comment about the split of l…
lennart0901 Nov 9, 2014
3fc7a0b
Rename a test_linestyle_accent to test_linestyle_variants and change …
lennart0901 Nov 10, 2014
9108a4b
Add test for specifying a single dash pattern as linestyle for a coll…
lennart0901 Nov 11, 2014
0ec4e67
Document split of `matplotlib.cbook.ls_mapper` in api_changes
lennart0901 Nov 11, 2014
e6718ca
Add new entry for unified linestyle handling to whats_new.
lennart0901 Nov 12, 2014
a09d4ad
ENH : raise on invalid linestyle
tacaswell Nov 18, 2014
8b90be7
BUG : properly handle 'none' as linestyle
tacaswell Nov 18, 2014
7858040
TST : import nose so 2.6 fails gracefully
tacaswell Nov 20, 2014
937248d
Correct parameter name to match documentation in Line2D.set_linestyle
lennart0901 Nov 28, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
BUG : properly handle 'none' as linestyle
  • Loading branch information
@tacaswell @lennart0901
tacaswell authored and lennart0901 committed Apr 14, 2015
commit 8b90be769b071016554aaba3b1f850ab60f0e47f
13 changes: 8 additions & 5 deletions lib/matplotlib/lines.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -976,15 +976,18 @@ def set_linestyle(self, linestyle):
linestyle = '-'
break

if linestyle in [' ', '', 'none']:
linestyle = 'None'

if linestyle not in self._lineStyles:
try:
linestyle = ls_mapper_r[linestyle]
except KeyError:
raise ValueError("You passed in an invalid linestyle, see "
"docs of Line2D.set_linestyle for "
"valid values")
if linestyle in [' ', '']:
linestyle = 'None'
raise ValueError(("You passed in an invalid linestyle, "
"`{}`. See "
"docs of Line2D.set_linestyle for "
"valid values.").format(linestyle))

self._linestyle = linestyle

@docstring.dedent_interpd
Expand Down
0