fixed axvline description of ymin/ymax args. Little edit in axhline doc #3698
Conversation
|
Could you rebase your branch (do this first!) and th 8000 en run boilerplate.py to update pyplot.py? |
|
No need to rebase (I fetched and merged master just before checking out the new branch about an hour ago). Is the same if I run boilerplate with python2 or puthon3? |
|
|
|
@montefra Can you rebase and re-run boilerplate.py? |
|
@tacaswell: rebased against the master and run boilerplate.py. The latter didn't change any file, so no new commit. |
|
boilerplate runs against the installed mpl, not the source version. Your second commit is removing things that should be in boilerplate and not updating the docs for things it should. |
|
@tacaswell I didn't know that. I guess that I should run |
|
That would work. |
|
I hope that now it works |
|
Ah, sorry, I was confused about the the docs in pyplot worked, but it is correct now. Assuming travis reports back positive this looks good to merge! |
|
It's working. The only failure is PEP8: I didn't run vim pep8 before committing and one of the lines I've edited is 81 characters long. I can commit the fix. BTW: my vim-flake8 on the |
|
Have a look at https://github.com/matplotlib/matplotlib/blob/master/lib/matplotlib/tests/test_coding_standards.py#L21 for the pep8 rules we ignore as part of the automated tests and I think flake8 also checks non-code style issues (which we should probably fix, but don't automate testing on). |
|
Yes it looks like boilerplate.py does not respect pep8. Shouldn't the changes to pyplot.py be completely dropped from this pr? They are not relevant to the docs changed and are just rearrangements of kwargs |
|
@tacaswell: thanks for the link. All the E??? error codes that I see are the ones ignored. Plus there are a bunch of F??? warnings (about non used variables or redefinition) @jenshnielsen: my second boilerplate.py commit (5c4f2a6) was to undo the error I've done with the second commit 9b50e46 |
|
@montefra yes the alternative would be to rebase and drop both commits but this is fine with me. I did not notice that you had already pushed the latest commit when I wrote that stuff above, |
|
The last failure looks like a random fluke. Restarted |
DOC : fixed axvline description of ymin/ymax args. Little edit in axhline doc
No description provided.