refactor ftface_props example #3630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not a huge fan of this change, I think it hides the bit-shift logic under a bit too much clever. |
|
Haven't looked at this file in a while. Note that these constants are now defined in the ft2font extension itself, so there's no need to recreate their values here. i.e., one can just do |
|
@mdboom just found a typo in the values of the style identifiers in ft2font.cpp What do you think about my last commit. Is it still too clever? |
Signed-off-by: Thomas Hisch <t.hisch@gmail.com>
Signed-off-by: Thomas Hisch <t.hisch@gmail.com>
Signed-off-by: Thomas Hisch <t.hisch@gmail.com>
|
rebased |
|
Thanks. The typo fixed here is legit. Thanks for catching. I think the latest version of the example file here is much better, and not "too clever". 👍 from me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BTW this fixes many pep8 errors in this file