8000 remove point troubling regex by MarieSacksick · Pull Request #30097 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

remove point troubling regex #30097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2025
Merged

remove point troubling regex #30097

merged 1 commit into from
May 23, 2025
+1 −1

Conversation

MarieSacksick
Copy link
Contributor

PR summary

The documentation in API menu is cropped because of a point in the middle of the sentence.
image

PR checklist

@github-actions github-actions bot added the Documentation: plot types files in galleries/plot_types label May 23, 2025
github-actions[bot]
github-actions bot reviewed May 23, 2025
View reviewed changes
Copy link
@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@MarieSacksick MarieSacksick marked this pull request as ready for review May 23, 2025 10:02
@timhoffm
Copy link
Member

Thanks. I think this could better be solved on the sphinx/autosummary side by adding to https://github.com/tk0miya/sphinx/blob/c4f0d70d173393a167bd20af1cd2153e06e6b5ae/sphinx/ext/autosummary/__init__.py#L102

@MarieSacksick MarieSacksick mentioned this pull request May 23, 2025
Open
@MarieSacksick
Copy link
Contributor Author

PR ongoing here in sphinx: sphinx-doc/sphinx#13591

story645
story645 approved these changes May 23, 2025
View reviewed changes
Copy link
Member
@story645 story645 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is such a light change that I think we may as well also fix it on the mpl side rather than waiting on the sphinx release cycle. Especially since versus is already spelled out in the other descriptions to get around this.

@jklymak
Copy link
Member
jklymak commented May 23, 2025

Yes, the PR request to sphinx makes sense, but also vs. is not necessary

@jklymak jklymak merged commit 9cf3990 into matplotlib:main May 23, 2025
21 checks passed
@story645
Copy link
Member

Thanks for catching and fixing this @MarieSacksick, hope to see you around more!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@story645 story645 story645 approved these changes

Assignees
No one assigned
Labels
Documentation: plot types files in galleries/plot_types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MarieSacksick @timhoffm @jklymak @story645
0