-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Update pinned oldest win image on azure #29992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The windows-2019 image will be deprecated on 1.6.2025. Also, this is a test whether the timeouts matplotlib#29797 are related to the windows-2019 image.
First run did not exhibit timeout. Force push to rerun CI. Let's check whether this is reliable by running CI multiple times. |
Second run did not exhibit timeout. Force push to rerun CI. |
This did not have timeouts three times in a row. I suggest to merge this and see whether our timouts are gone. We would have to update the image in a month anyway due to the deprecation, and I don't think it's a relevant miss if we don't run the windows-2019 image. |
There is an if-loop at line 123 that the comment states is for windows-2019. I guess that can be removed. |
The windows-2019 image will be deprecated on 1.6.2025. Also, this is a test whether the timeouts matplotlib#29797 are related to the windows-2019 image.
I'm guessing but not 100% this wants to be backported, so I've milestoned for that on the basis that it's easier to have the backports opened and close them if not wanted than having to manually backport. |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
…ge on azure (cherry picked from commit ab102c0)
….10.x Backport PR #29992 on v3.10.x: Update pinned oldest win image on azure
…9992-on-v3.10.x Backport PR matplotlib#29992 on v3.10.x: Update pinned oldest win image on azure (cherry picked from commit acb7361)
… image on azure I diverged from instructions and cherry-picked the commit from the v3.10.x branch, since that produced no conflicts. (cherry picked from commit acb7361)
Note: This seems not to fix it completely. This is a run with windows-2022 and it still produces a timeout. 😢 I'm not yet taking any further action, like repoening #29981, yet. Let's monitor the situation further. |
The windows-2019 image will be deprecated on 1.6.2025 (#29797 (comment)). Also, this is a test whether the timeouts #29797 are related to the windows-2019 image.