8000 fix FuncAnimation class by Lynsoo · Pull Request #29967 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]

Skip to content

fix FuncAnimation class #29967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Conversation

Lynsoo
Copy link
@Lynsoo Lynsoo commented Apr 25, 2025

PR summary

  • Why is this change necessary?

  • To ensure the update function passed to FuncAnimation matches expected signatures and avoids runtime errors.

  • What problem does it solve?

  • It prevents type errors and ensures the animation updates frames correctly without freezing or crashing.

  • What is the reasoning for this implementation?

  • FuncAnimation requires different update function return types depending on blit, typing must reflect this to satisfy static checkers and runtime behavior.

Closes #29960

PR checklist

Copy link
@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@Lynsoo Lynsoo marked this pull request as draft April 25, 2025 19:59
@Lynsoo Lynsoo closed this by deleting the head repository Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: FuncAnimation function not typed properly
1 participant
0