10000 FIX: Correct variable name from _frame to _frames in PillowWriter class by Anselmoo · Pull Request #29520 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

FIX: Correct variable name from _frame to _frames in PillowWriter class #29520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 27, 2025
Merged

FIX: Correct variable name from _frame to _frames in PillowWriter class #29520

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e59706f
FIX: Correct variable name from _frame to _frames in PillowWriter class
Anselmoo Jan 25, 2025
d9193df
test: Add test for animation with transparency and exhausted warning
Anselmoo Jan 26, 2025
0be53be
TEST: Update animation test to use PillowWriter for transparency hand…
Anselmoo Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/matplotlib/animation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,7 +496,7 @@
"RGBA", self.frame_size, buf.getbuffer(), "raw", "RGBA", 0, 1)
if im.getextrema()[3][0] < 255:
# This frame has transparency, so we'll just add it as is.
self._frame.append(im)
self._frames.append(im)

Check warning on line 499 in lib/matplotlib/animation.py

View check run for this annotation

Codecov / codecov/patch

lib/matplotlib/animation.py#L499 

Added line #L499 was not covered by tests
else:
# Without transparency, we switch to RGB mode, which converts to P mode a
# little better if needed (specifically, this helps with GIF output.)
Expand Down
Loading
0