CI: add py312 and py313 on windows on azure to test matrix #29473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A change like this should fix the test: diff --git a/lib/matplotlib/tests/test_animation.py b/lib/matplotlib/tests/test_animation.py
index 6a9f31733f..a2b35f802c 100644
--- a/lib/matplotlib/tests/test_animation.py
+++ b/lib/matplotlib/tests/test_animation.py
@@ -520,7 +520,7 @@ def test_disable_cache_warning(anim):
def test_movie_writer_invalid_path(anim):
if sys.platform == "win32":
- match_str = r"\[WinError 3] .*'\\\\foo\\\\bar\\\\aardvark'"
+ match_str = r"\[WinError 3] .*\\\\foo\\\\bar\\\\aardvark'"
else:
match_str = r"\[Errno 2] .*'/foo"
with pytest.raises(FileNotFoundError, match=match_str): |
|
Do we understand what changed in py313? From looking at the failing string it looks like Python now includes the full path with a drive? Strongly suspect it is python/cpython#119826 making an internal |
|
That seems related from the changelog, but it was backported to 3.12.8, which didn't fail that first time. |
|
Interesting. However, given that this is the text of an error message (and I think including the drive letter is better) I don't think it is worth spending too much time to track it down. |
QuLogic
approved these changes
Jan 17, 2025
|
Could be python/cpython#126780 as the input is a drive-relative path on Windows, and this wasn't backported to 3.12. |
timhoffm
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noted will looking at #29472 that we are only testing py310 and py311 on either windows platform.