Fix dead links in dev workflow docs #29463
Conversation
|
On a side-note, please don't name PRs like |
|
I've tried to resolve the issue, but I guess the checks still didn't pass. I am open to all your suggestions, please guide me where I am doing things wrong since I am in my learning process :) |
|
To fix the PR cleanliness check, you can squash the commits into one with an interactive rebase. |
|
Thankyou @rcomer for the help :) |
|
I think you can also use interactive rebase to drop the "attach_note" commit. For future PRs, you should create a separate feature branch, and then you don't get this problem. |
|
Sure @rcomer I'll keep that in mind. |
doc/devel/development_workflow.rst
Outdated
| @@ -138,13 +138,10 @@ The editing workflow | |||
| Note the ``-am`` options to ``commit``. The ``m`` flag signals that you are | |||
| going to type a message on the command line. The ``a`` flag stages every | |||
| file that has been modified, except files listed in ``.gitignore``. For more | |||
| information, see `why the -a flag?`_ and the | |||
| `git commit <https://git-scm.com/docs/git-commit>`_ manual page. | |||
| information, see `git commit <https://git-scm.com/docs/git-commit>`_ manual page. | |||
There was a problem hiding this comment.
| information, see `git commit <https://git-scm.com/docs/git-commit>`_ manual page. | |
| information, see the `git commit <https://git-scm.com/docs/git-commit>`_ manual page. |
There was a problem hiding this comment.
okay I'll fix it
- Removed unnecessary sentence in the development workflow. - Fixed broken link in `development_w 8000 orkflow.rst`.
PR summary
Closes #29305.
PR checklist