8000 Remove some unused resample code by QuLogic · Pull Request #29450 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Remove some unused resample code #29450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 31, 2025
Merged

Remove some unused resample code #29450

merged 2 commits into from
Jan 31, 2025

Conversation

QuLogic
Copy link
Member
@QuLogic QuLogic commented Jan 10, 2025

PR summary

Looking at some of the resampling code, and these bits appear unused.

PR checklist

@tacaswell tacaswell added this to the v3.11.0 milestone Jan 10, 2025
@tacaswell
Copy link
Member

Did we ever use these or were they added as belt-and-suspenders ?

@QuLogic
Copy link
Member Author
QuLogic commented Jan 10, 2025

I see many typedefs of pixfmt_pre_type over the years, but no actual usage anywhere.

@tacaswell
Copy link
Member

Can we at least leave a comment to check for the removed code in history if we ever need it?

tacaswell
tacaswell approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member
@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to leave a breadcrumb for the future, but not going to block merging over that.

oscargus
oscargus approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member
@oscargus oscargus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the point of adding some sort of breadcrumb, but feel free to self merge if deemed not required (or self merge after adding that).

@tacaswell
Copy link
Member

The appveyor failure looks unrelated (sphinx tests + races cleaning up temporary files).

@tacaswell tacaswell merged commit 5714a18 into matplotlib:main Jan 31, 2025
39 of 40 checks passed
@QuLogic QuLogic deleted the unused-resample branch January 31, 2025 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@oscargus oscargus oscargus approved these changes

Assignees
No one assigned
Labels
topic: images
Projects
None yet
Milestone
v3.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@QuLogic @tacaswell @oscargus
0