Type annotation add_subplot for projection="3d" #29341
Merged
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me at a glance - is there still interest in merging this? It's currently marked as draft. |
|
I'd still like to see this, or something like it, merged! |
timhoffm
approved these changes
May 1, 2025
d623524 to
3b60169
Compare
3b60169 to
81f6ba3
Compare
timhoffm
reviewed
May 1, 2025
lib/matplotlib/figure.pyi
Outdated
| @@ -25,6 +25,9 @@ from matplotlib.lines import Line2D | |||
| from matplotlib.patches import Rectangle, Patch | |||
| from matplotlib.text import Text | |||
| from matplotlib.transforms import Affine2D, Bbox, BboxBase, Transform | |||
| if TYPE_CHECKING: | |||
There was a problem hiding this comment.
Actually, this guard is not needed in .pyi files, because they are only used for tyoechecking.
dstansby
approved these changes
May 2, 2025
timhoffm
approved these changes
May 2, 2025
|
Thank you! |
|
Is there a timeline for this to be available in an official release? |
79A7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof-of-concept PR to address #29334