8000 Minor cleanups to docstrings, comments, and error messages. by anntzer · Pull Request #29172 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]

Skip to content

Minor cleanups to docstrings, comments, and error messages. #29172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Nov 22, 2024

PR summary

PR checklist

Copy link
Member
@oscargus oscargus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subject to the obvious test fix.

Comment on lines 1204 to 1205
_api.check_isinstance(
(Figure, int, str, None), fig=fig) # type: ignore[unreachable]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment should go on the first line, I think.

Suggested change
_api.check_isinstance(
(Figure, int, str, None), fig=fig) # type: ignore[unreachable]
_api.check_isinstance( # type: ignore[unreachable]
(Figure, int, str, None), fig=fig)

@timhoffm timhoffm merged commit 31b1b91 into matplotlib:main Nov 24, 2024
40 of 43 checks passed
@anntzer anntzer deleted the clean branch November 24, 2024 08:39
@QuLogic QuLogic modified the milestones: v3.10.0, v3.11.0 Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0