8000 FIX: Update GTK3Agg backend export name for consistency by greglucas · Pull Request #29085 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

FIX: Update GTK3Agg backend export name for consistency #29085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2024
Merged

FIX: Update GTK3Agg backend export name for consistency #29085

merged 1 commit into from
Nov 5, 2024

Conversation

greglucas
Copy link
Contributor

PR summary

Reading through the code I found it weird that the backend export class is called "Cairo" within the "Agg" section, I think this was just a typo originally in #8773. The actual monkeypatching happens based on the module name,

matplotlib/lib/matplotlib/backend_bases.py

Line 3562 in 0b6222b

setattr(sys.modules[cls.__module__], name, getattr(cls, name))

not this class so we were using the proper Agg/Cairo renderers as expected. This just helps with naming consistency when looking through the code.

@QuLogic QuLogic added this to the v3.10.0 milestone Nov 5, 2024
@QuLogic QuLogic merged commit 1155eab into matplotlib:main Nov 5, 2024
42 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Nov 5, 2024
@QuLogic @meeseeksmachine
Backport PR matplotlib#29085: FIX: Update GTK3Agg backend export name…
43f84aa 
… for consistency
@meeseeksmachine meeseeksmachine mentioned this pull request Nov 5, 2024
Merged
@greglucas greglucas deleted the gtk-agg-class branch November 5, 2024 23:17
QuLogic added a commit that referenced this pull request Nov 6, 2024
@QuLogic
Merge pull request #29091 from meeseeksmachine/auto-backport-of-pr-29…
40d01e6 
…085-on-v3.10.x

Backport PR #29085 on branch v3.10.x (FIX: Update GTK3Agg backend export name for consistency)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
GUI: gtk
Projects
None yet
Milestone
v3.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@greglucas @QuLogic @timhoffm
0