Fix Cairo text on Python3 with pycairo #2906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
added a commit
that referenced
this pull request
Mar 24, 2014
Fix Cairo text on Python3 with pycairo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are three possible cairo wrappers that we support:
py2cairoon Python 2.x,pycairoon Python 3.x andcairocffion both. Unfortunately, they want to receive strings differently.py2cairoexpects them as utf-8-encoding byte strings. The other two expect Python unicode strings.This fixes the one case we missed in the recent changes to support cairocffi: when on Python 3.x with pycairo, we need to give the wrapper unicode strings.
Replaces #2905. Fixes #2903.