8000 MNT: expire `ContourSet` deprecations by rcomer · Pull Request #28767 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

MNT: expire ContourSet deprecations #28767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2024
Merged

MNT: expire ContourSet deprecations #28767

merged 1 commit into from
Sep 7, 2024

Conversation

rcomer
Copy link
Member
@rcomer rcomer commented Aug 29, 2024 •
edited
Loading

PR summary

Expire the v3.8 deprecations for ContourSet. The two methods removed from ContourLabeller seem to have been really intended for internal use and I couldn't find a v3.8 changenote for them, so I didn't add a changenote for them here either.

PR checklist

@rcomer rcomer added this to the v3.10.0 milestone Aug 29, 2024
@rcomer
Copy link
Member Author
rcomer commented Aug 29, 2024

There will come a day when I remember to think about type hints before I push, but today is not that day.

@rcomer rcomer force-pushed the contour-deprecations branch from c281412 to 8bd131d Compare August 29, 2024 19:42
QuLogic
QuLogic reviewed Aug 29, 2024
View reviewed changes
@rcomer rcomer force-pushed the contour-deprecations branch from 8bd131d to 3096bc8 Compare August 30, 2024 18:12
rcomer
rcomer commented Aug 30, 2024
View reviewed changes
doc/api/next_api_changes/removals/28767-REC.rst
or `~.Collection.get_linewidths` instead.


``calc_label_rot_and_inline`` method of ``ContourLabeler``
Copy link
Member Author
@rcomer rcomer Aug 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I first did this as ContourLabeler.calc_label_rot_and_inline, but that rendered as an unwrapped line that was too wide to show properly on my laptop screen.

QuLogic
QuLogic reviewed Aug 30, 2024
View reviewed changes
@rcomer rcomer force-pushed the contour-deprecations branch from 3096bc8 to e28d5ee Compare August 31, 2024 08:43
@ksunden ksunden merged commit 4310fff into matplotlib:main Sep 7, 2024
43 checks passed
@rcomer rcomer deleted the contour-deprecations branch September 7, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@ksunden ksunden ksunden approved these changes

Assignees
No one assigned
Labels
API: changes topic: contour
Projects
None yet
Milestone
v3.10.0
4124
Development

Successfully merging this pull request may close these issues.
3 participants
@rcomer @QuLogic @ksunden
0