8000 DOC: Fix version switcher for stable docs by QuLogic · Pull Request #28512 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]

Skip to content

DOC: Fix version switcher for stable docs #28512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2024

Conversation

QuLogic
Copy link
Member
@QuLogic QuLogic commented Jul 5, 2024

PR summary

This should stop the banner from showing up on stable.

PR checklist

This should stop the banner from showing up on stable.
@story645
Copy link
Member
story645 commented Jul 5, 2024

Is this what's supposed to be fixed? And can it only be fixed after merging? This is taken from the artifacts job on this PR:

Screenshot_20240705-171051.png

@QuLogic
Copy link
Member Author
QuLogic commented Jul 5, 2024

Yea, it won't be fixed until merged, as everything pulls that json file from devdocs.

Copy link
Member
@story645 story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not merging cause I'm confused how merging to main fixes issues w/ 3.9 docs - is this supposed to be backported-but I figure @QuLogic knows the answer to this.

@QuLogic
Copy link
Member Author
QuLogic commented Jul 6, 2024

All docs pull switcher.json from devdocs; there's no need to backport. The version just needs to match.

@QuLogic QuLogic merged commit 9f31b01 into matplotlib:main Jul 6, 2024
25 checks passed
@QuLogic QuLogic added this to the v3.10.0 milestone Jul 6, 2024
@QuLogic QuLogic deleted the fix-stable branch July 6, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0