8000 Add Quiverkey zorder option by muchojp · Pull Request #28354 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Add Quiverkey zorder option #28354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
QuLogic merged 7 commits into from
Oct 18, 2024
Merged

Add Quiverkey zorder option #28354

QuLogic merged 7 commits into from
Oct 18, 2024

Conversation

@muchojp
Copy link
Contributor
@muchojp muchojp commented Jun 6, 2024 •
edited
Loading

PR summary

Add zorder option in QuiverKey. So far, if you want to set zorder, you need set_zorder.
Therefore, I add option in QuiverKey.
This PR enhance API consistency.

PR checklist

muchojp and others added 2 commits June 5, 2024 23:05
@muchojp muchojp force-pushed the quiverkey_zorder branch from 7a5be27 to 106312f Compare June 6, 2024 13:43
@muchojp muchojp changed the title Quiverkey zorder Add Quiverkey zorder option Jun 6, 2024
@muchojp muchojp force-pushed the quiverkey_zorder branch 2 times, most recently from be7574c to 366dfd0 Compare June 8, 2024 21:20
@muchojp muchojp force-pushed the quiverkey_zorder branch from e8f764a to adf13e7 Compare June 8, 2024 23:42
timhoffm
timhoffm approved these changes Sep 20, 2024
View reviewed changes
@muchojp @timhoffm
Update doc/api/next_api_changes/behavior/28354-YN.rst
0f43090 
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
@QuLogic
Copy link
Member
QuLogic commented Oct 17, 2024

To fix doc builds, you'll need to rebase against or merge to main from here.

Sorry, something went wrong.

QuLogic
QuLogic reviewed Oct 18, 2024
View reviewed changes
muchojp and others added 2 commits October 18, 2024 23:05
@muchojp @QuLogic
Update lib/matplotlib/tests/test_quiver.py
890e1cd 
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@muchojp @QuLogic
Update lib/matplotlib/quiver.py
54da2ce 
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@QuLogic QuLogic added this to the v3.10.0 milestone Oct 18, 2024
@QuLogic QuLogic merged commit f50efa5 into matplotlib:main Oct 18, 2024
@QuLogic
Copy link
Member
QuLogic commented Oct 18, 2024

Thanks @muchojp! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again.

@muchojp
Copy link
Contributor Author
muchojp commented Oct 18, 2024

@timhoffm @QuLogic
I appreciate your support! 😄 See you again.

@muchojp muchojp deleted the quiverkey_zorder branch October 18, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

567F

Assignees

No one assigned

Labels

API: consistency

Projects

First Time Contributors
Status: Merged

Milestone

v3.10.0

Development

Successfully merging this pull request may close these issues.

4 participants

@muchojp @QuLogic @timhoffm @melissawm
0