BUGFIX: This change fixes #2475 #2809
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… manually produce ugly spikes in the contours. The problem was that screen coordinates were being passed as data coordinates when the contour was split to add room for the label.
|
I don't think #2809 actually fixes #2475, since the problem occurs when |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding contour labels added manually produce ugly spikes in the contours. The problem was that screen
coordinates were being passed as data coordinates when the contour was split to add room for the label. xcmin in the add_label_near() method should contain data coordinates, and if transform=False was used (as it does in the BlockingContourLabeler), they were left in screen coordinates, causing the new vertices of the clipped contours to be in the wrong location.