8000 qhull: Fix inconsistent formatting function arguments by QuLogic · Pull Request #27987 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

qhull: Fix inconsistent formatting function arguments #27987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

qhull: Fix inconsistent formatting function arguments #27987

wants to merge 2 commits into from
+426 −0

Conversation

QuLogic
Copy link
Member
@QuLogic QuLogic commented Mar 28, 2024

PR summary

This is a backport of qhull/qhull#143, and should fix all of the related CodeQL alerts.

PR checklist

@QuLogic QuLogic force-pushed the qhull-printf-fixes branch from 547d7ad to 3889c1c Compare March 28, 2024 09:33
@QuLogic
Copy link
Member Author
QuLogic commented Mar 28, 2024

Hmm, I don't know where to find the results for CodeQL when a PR fixes alerts (unless it didn't fix them of course.)

@QuLogic QuLogic marked this pull request as draft March 28, 2024 23:57
@QuLogic
Copy link
Member Author
QuLogic commented Mar 29, 2024

I pushed this to main on my fork, and it did drop CodeQL alerts by 13. Unfortunately, the patch was broken for Windows wheels due to Strawberry Perl's broken patch command. I think there's something in Meson upstream to fix that, but I'm not sure the state of it.

@QuLogic QuLogic force-pushed the qhull-printf-fixes branch from 3889c1c to 59abbca Compare July 5, 2024 06:46
@QuLogic QuLogic marked this pull request as ready for review July 5, 2024 08:47
@QuLogic QuLogic added Build CI: Run cibuildwheel Run wheel building tests on a PR labels Jul 5, 2024
@QuLogic
Copy link
Member Author
QuLogic commented Jul 5, 2024

It looks like the latest Meson picks a suitable patch implementation on Windows, so this is good now.

@QuLogic
Copy link
Member Author
QuLogic commented Jul 5, 2024

But then wheel building shows up 3 times, but is actually failing.

@QuLogic QuLogic marked this pull request as draft July 5, 2024 09:23
QuLogic added 2 commits July 2, 2025 17:34
@QuLogic
qhull: Fix inconsistent formatting function arguments
9fe911e 
This is a backport of qhull/qhull#143, and
should fix all of the related CodeQL alerts.
@QuLogic
ci: Purge Strawberry Perl from Windows builders
2016a27 
We don't use Perl, and it includes a completely busted version of
`patch`.
@QuLogic QuLogic force-pushed the qhull-printf-fixes branch from 59abbca to 2016a27 Compare July 2, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Build CI: Run cibuildwheel Run wheel building tests on a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@QuLogic
0