Highlight development_setup code snippets as bash, not python. #27931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This looks much better and is consistent with development_workflow.rst and release_guide.rst, which rely on the same mechanism.
dstansby
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
Definitely an improvement; there's some windows commands about halfway down that are now have odd highlighting:
Since this is a minor change and improvement I'll approve but not merge in case you want to fix that in this PR; if you want to punt that to a new issue or PR feel free to self-merge.
|
I don't think you can have two different highlighters in a single code block, so I guess the proper fix would be to split that into multiple code blocks but let's just get this in for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks much better and is consistent with development_workflow.rst and release_guide.rst, which rely on the same mechanism.
PR summary
PR checklist