Deleting all images that have passed tests before upload #27882
Conversation
Modified code to delete all types of files which have not failed Minor extension handling Checking if file exists before deleting Did not delete directories
|
Hey, could someone help me out on how to resolve the failing tests? |
|
@Impaler343 those tests seem to be a bit flakey at the moment as they are failing across multiple PRs. I have re-spun them so we can see if they pass this time. |
.github/workflows/tests.yml
Outdated
| if [[ -e "${base}.$extension" ]]; then | ||
| rm "${base}.$extension" | ||
| fi | ||
| echo "Removed $file" |
There was a problem hiding this comment.
| echo "Removed $file" | |
| echo "Removed ${base}.$extension" |
?
There was a problem hiding this comment.
Fixed that. Another thing - Should I delete all empty folders inside the result_images folder? Or leave it as it is
There was a problem hiding this comment.
I think leaving empty directories is not something worth holding the PR over, but if it is easy no reason not to do it.
There was a problem hiding this comment.
I guess this works well as it is, don't want to break anything in the process
|
I guess this is ready to merge, do you expect any more changes from my side? |
|
@Impaler343 since @tacaswell already approved this one, you now need a second reviewer to also approve and then it can be merged (we require two approvals for most things except documentation changes). |
|
ping @QuLogic, as he had reviewed a similar PR. Please review :) |
PR summary
Supersedes PR #27881 (I'm so sorry for creating unnecessary traffic on this repo.)
Attempts to close #23400 and potentially complete what PR #19466 intended to do
Included a bash script right before the uploading part of the code in the tests.yml file to delete all files(.png, .svg, .eps, .pdf) that have not failed in the result_images directory. Have tested this using a dummy bash file and the downloaded result_images folder. Please let me know if this approach seems correct, or is blatantly wrong :).
PR checklist