8000 Use GH action to install reviewdog by dstansby · Pull Request #27619 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]

Skip to content

Use GH action to install reviewdog #27619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Conversation

dstansby
Copy link
Member
@dstansby dstansby commented Jan 9, 2024

PR summary

I presume this is more recent than when reviewdog was setup. Saves a few lines and makes for easier maintenance in the future.

PR checklist

@dstansby dstansby changed the title Use action to install reviewdog Use GH action to install reviewdog Jan 9, 2024
@dstansby dstansby added Maintenance CI: testing CI configuration and testing labels Jan 9, 2024
@dstansby dstansby added this to the v3.9.0 milestone Jan 9, 2024
@dstansby dstansby marked this pull request as ready for review January 9, 2024 15:23
@ksunden
Copy link
Member
ksunden commented Jan 9, 2024

I guess my personal opinion is that if we are going to curl | sh, I'd rather be up front about it and not hide it in layers of obfuscation... (That is, in fact, what reviewdog's action does, modulo allowing wget instead of curl and the precise location that it gets installed to)

It just feels like we are adding steps and not getting any benefit from it, and just making it harder to figure out what went wrong if it does go wrong (though the counterargument there is that we would have other people looking for the error simultaneously).

@ksunden
Copy link
Member
ksunden commented Jan 9, 2024

It does look like there was a temporary problem affecting some PRs where the install script required an argument but that appears to have been reverted such that no argument is equivalent to "latest"

@dstansby
Copy link
Member Author

I was thinking if they change the URL it's one less thing to maintain on our end, and I think having other eyes on it so bugs get reported and fixed faster outweights us having to track down something by ourselves when it goes wrong. There are reportedly 1.9k repos using the action, so it is widely used.

Copy link
Member
@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favor of deferring this to an action.

@ksunden ksunden merged commit 879bde7 into matplotlib:main Jan 17, 2024
@dstansby dstansby deleted the reviewdog-action branch January 18, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: testing CI configuration and testing Maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0