8000 MAINT: fix .yml in tag issue template by story645 · Pull Request #27275 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]

Skip to content

MAINT: fix .yml in tag issue template #27275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

story645
Copy link
Member
@story645 story645 commented Nov 6, 2023

FIxes the yml for the new tag template by escaping the space after the : actions/runner#1019 (comment) - am open to other suggestions but yaml really does not like colons.

@story645 story645 added Maintenance Documentation: tags tagging examples + proposing new tags labels Nov 6, 2023
@QuLogic
Copy link
Member
QuLogic commented Nov 7, 2023

The entire value should be quoted to use colons, I believe, but it's difficult to say if that needs to be done a few times depending on what might read the value.

@story645
Copy link
Member Author
story645 commented Nov 7, 2023

Tried that, mix of " an ' and I couldn't get it to work.

@story645
Copy link
Member Author
story645 commented Nov 7, 2023

clearly I'm just gonna throw things at the wall and see what works and then either rebase or ask you to squash

< 8000 input type="hidden" data-csrf="true" name="authenticity_token" value="s0XVl80q3OogSlXybwalkVp0xfI1fMZZhkdgDYqr2v2+VDeeE27q1udBWpcl70yDrGYcxC71OipvtgiSUM12Ng==" />

@story645 story645 marked this pull request as draft November 7, 2023 00:51
@story645 story645 marked this pull request as ready for review November 7, 2023 06:27
@story645
Copy link
Member Author
story645 commented Nov 7, 2023

@story645 story645 force-pushed the tag-issue-template branch 2 times, most recently from 78f5094 to 3c99345 Compare November 8, 2023 19:13
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@ksunden ksunden merged commit 477eecf into matplotlib:main Nov 8, 2023
@ksunden ksunden added this to the v3.9.0 milestone Nov 8, 2023
@story645 story645 deleted the tag-issue-template branch November 8, 2023 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation: tags tagging examples + proposing new tags Maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0