API: finish LocationEvent.lastevent removal #27218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
91a67d9 to
e38ed3e
Compare
|
This is a 3.8 deprecation; it needs to wait for 3.10. |
tacaswell
commented
Sep 18, 2024
ksunden
approved these changes
Sep 18, 2024
fbeb2cc to
00477f6
Compare
00477f6 to
f6a7188
Compare
QuLogic
approved these changes
Sep 18, 2024
|
I don't think this could have affected the tests that are failing, as those are a macOS/Azure problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Remove a scheduled deprecation of holding a hard reference to the last event.
PR checklist