Reorder safe_first_element() and _safe_first_finite() code #26819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not change functionality. The code path for `safe_first_element` is `_safe_first_finite(skip_nonfinite=False)` which is separate code block and does not interact with the skip_nonfinite=True case. IMHO this is more readable. Also add a comment on the exception handling recently modified in matplotlib#26806.
tacaswell
approved these changes
Sep 18, 2023
oscargus
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not change functionality. The code path for
safe_first_elementis_safe_first_finite(skip_nonfinite=False)whichis separate code block and does not interact with the
skip_nonfinite=True case. IMHO this is more readable.
Also add a comment on the exception handling recently modified in #26806.