specify input range in logs when image data must be clipped#26802
specify input range in logs when image data must be clipped#26802rcomer merged 1 commit intomatplotlib:mainfrom MarcBresson:main
Conversation
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
There was a problem hiding this comment.
This seems reasonable to me. I have to admit I didn't know we used logging warnings anywhere... 👀
|
Congratulations on your first PR in Matplotlib @MarcBresson! We hope to hear from you again. |
|
You are welcome! I discovered warnings when my log file was a few mega bytes large. There are 48 different warnings in matplotlib, but some of them are in not accessed functions (which is strange). Here is an instance of not accessed function according to my pylance: matplotlib/lib/matplotlib/__init__.py Lines 1304 to 1319 in 6fa5045 |
|
That is only accessible in certain build configurations. |
PR summary
When matplotlib clip image data because it is out of range, it could be useful to know what range was actually inputted. This PR print the given range in the logs.
PR checklist