8000 [Doc]: matched 3d plots titles with others by AmirAflak · Pull Request #26488 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]

Skip to content

[Doc]: matched 3d plots titles with others #26488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

AmirAflak
Copy link
Contributor

PR summary

closes #26486

PR checklist

Copy link
@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@AmirAflak AmirAflak changed the title [DOC]: matched 3d plots titles with others [Doc]: matched 3d plots titles with others Aug 11, 2023
@story645 story645 added the Documentation: plot types files in galleries/plot_types label Aug 14, 2023
@AmirAflak
Copy link
Contributor Author

could you please review my pull request? I have addressed all the requested changes and would appreciate your feedback. Thank you!

3D voxel / volumetric plot
==========================
=================
voxels([x, y, z])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
voxels([x, y, z])
voxels([x, y, z], filled)

filled (which makes no indication about structure) is the required argument, not [x,y,z] -far as I can tell reading the docs

@story645
Copy link
Member

@AmirAflak did you intend to close this? The only reason this isn't merged is because of the missing 'filled' argument - if you add that in then I'll merge.

@ksunden
Copy link
Member
ksunden commented Aug 21, 2023

I think this may have been closed automatically because you opened another PR from main, we recommend using a feature branch so that this does not happen.

@QuLogic
Copy link
Member
QuLogic commented Aug 22, 2023

Replaced by #26571.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

[Doc]: match 3D plot types listings titles to other titles
4 participants
0