8000 Fix return value of Text.update by QuLogic · Pull Request #26450 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Fix return value of Text.update #26450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2023
Merged

Fix return value of Text.update #26450

merged 1 commit into from
Aug 4, 2023

Conversation

QuLogic
Copy link
Member
@QuLogic QuLogic commented Aug 4, 2023

PR summary

The return value of Artist.update is a list of the results from calling the setters. However, while Text overrides update, it does not preserve that return value.

That being said, I do think almost all setters return None anyway...

PR checklist

@QuLogic
Fix return value of Text.update
8c689fa 
The return value of `Artist.update` is a list of the results from
calling the setters. However, while `Text` overrides `update`, it does
not preserve that return value.
@QuLogic QuLogic added this to the v3.8.0 milestone Aug 4, 2023
@QuLogic QuLogic mentioned this pull request Aug 4, 2023
Merged
1 task
@ksunden ksunden merged commit cb5d3ce into matplotlib:main Aug 4, 2023
@QuLogic QuLogic deleted the textupdate-return branch August 4, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksunden ksunden ksunden approved these changes

@oscargus oscargus oscargus approved these changes

Assignees
No one assigned
Labels
topic: typing
Projects
None yet
Milestone
v3.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@QuLogic @ksunden @oscargus
0