Some more micro optimizations #26344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/matplotlib/patches.py
Outdated
| @@ -72,7 +72,7 @@ def __init__(self, *, | |||
| joinstyle = JoinStyle.miter | |||
|
|
|||
| self._hatch_color = colors.to_rgba(mpl.rcParams['hatch.color']) | |||
| self._fill = True # needed for set_facecolor call | |||
| self._fill = fill # needed for set_facecolor call | |||
There was a problem hiding this comment.
Nitpick: to match previous behavior from set_fill, this should be bool(fill). But I'm not convinced we should be forcing a cast like that anyways.
There was a problem hiding this comment.
Well spotted! Fixed.
It is indeed a bit inconsistent over methods if arguments are casted to bool or not...
scottshambaugh
approved these changes
Jul 18, 2023
QuLogic
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
PR checklist