ENH: Collection.set_paths #26342
Merged
ENH: Collection.set_paths #26342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have also tested this for the Cartopy case. |
jklymak
approved these changes
Jul 18, 2023
greglucas
reviewed
Jul 19, 2023
lib/matplotlib/contour.py
Outdated
Comment on lines
980
to
982
| def set_paths(self, paths): | ||
| self._paths = paths | ||
| self.stale = True |
There was a problem hiding this comment.
I agree with @anntzer's comment #26340 (comment)
I think we could just add this change to Collection.set_paths(paths) method definition instead so others can also subclass and take advantage of it (could remove the method definition from PathCollection then too I think.
There was a problem hiding this comment.
Ah sorry, I misread @anntzer's comment. I've now updated Collection.set_paths. I left my test in because set_paths does not appear in test_collection.py. I assume the ContourSet is as good a place as any to make sure this code path is covered?
greglucas
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Closes #26340
I didn't add a changenote because I think this is covered by "Setting properties on the ContourSet can now usually be done using standard collection setters"
https://matplotlib.org/devdocs/api/next_api_changes/behavior/25247-AL.html
PR checklist