Deprecate unused "frac" key in annotate() arrowprops. #26080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksunden
reviewed
Jun 5, 2023
QuLogic
reviewed
Jun 5, 2023
lib/matplotlib/text.py
Outdated
Comment on lines
1843
to
1846
| if 'frac' in arrowprops: | ||
| _api.warn_deprecated( | ||
| "3.8", message="Support for passing the (unused) 'frac' key " | ||
| "has been removed %(since)s and will be removed %(removal)s.") |
There was a problem hiding this comment.
It's still only deprecated?
Suggested change
| if 'frac' in arrowprops: | |
| _api.warn_deprecated( | |
| "3.8", message="Support for passing the (unused) 'frac' key " | |
| "has been removed %(since)s and will be removed %(removal)s.") | |
| if 'frac' in arrowprops: | |
| _api.warn_deprecated( | |
| "3.8", name="The (unused) 'frac' key in *arrowprops*") | |
| arrowprops.pop('frac') |
Edit: Actually, it doesn't seem like you'd need to override the whole message, but you should add the context of where frac is.
timhoffm
approved these changes
Jun 6, 2023
timhoffm
approved these changes
Jun 6, 2023
This key has been unused for ~8y (197fc9f).
QuLogic
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This key has been unused for ~8y (197fc9f).
PR summary
PR checklist