8000 Cleanup demo_axes_grid{,2}. by anntzer · Pull Request #25885 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Cleanup demo_axes_grid{,2}. #25885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2023
Merged

Cleanup demo_axes_grid{,2}. #25885

merged 1 commit into from
May 14, 2023

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented May 13, 2023 •
edited
Loading
  • No point in tweaking the patch of the inner_titles because the patch is set to invisible (frameon=False).
  • No need to toggle the colorbar labels on (they are on by default).
  • Use clim=(min, max) instead of constructing an explicit Normalize instance.
  • Group axes tweaking in set() calls.
  • Remove unnecessary subplots_adjust.
  • Some reformatting.

PR summary

PR checklist

@anntzer anntzer changed the title Cleanup demo_axes_grid2. Cleanup demo_axes_grid{,2}. May 14, 2023
@anntzer
Cleanup demo_axes_grid{,2}.
de4e43c 
- No point in tweaking the patch of the inner_titles because the patch
  is set to invisible (frameon=False).
- No need to toggle the colorbar labels on (they are on by default).
- Use clim=(min, max) instead of constructing an explicit Normalize
  instance.
- Group axes tweaking in set() calls.
- Remove unnecessary subplots_adjust.
- Some reformatting.
@timhoffm timhoffm added this to the v3.7-doc milestone May 14, 2023
@timhoffm timhoffm merged commit 81661df into matplotlib:main May 14, 2023
@lumberbot-app
Copy link
lumberbot-app bot commented May 14, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.7.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 81661df26476249e5bf848b0a9050afa908bb10c
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #25885: Cleanup demo_axes_grid{,2}.'
  1. Push to a named branch:
git push YOURFORK v3.7.x:auto-backport-of-pr-25885-on-v3.7.x
  1. Create a PR against branch v3.7.x, I would have named this PR:

"Backport PR #25885 on branch v3.7.x (Cleanup demo_axes_grid{,2}.)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@lumberbot-app
Copy link
lumberbot-app bot commented May 14, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.7.1-doc
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 81661df26476249e5bf848b0a9050afa908bb10c
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #25885: Cleanup demo_axes_grid{,2}.'
  1. Push to a named branch:
git push YOURFORK v3.7.1-doc:auto-backport-of-pr-25885-on-v3.7.1-doc
  1. Create a PR against branch v3.7.1-doc, I would have named this PR:

"Backport PR #25885 on branch v3.7.1-doc (Cleanup demo_axes_grid{,2}.)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@anntzer anntzer deleted the dag2 branch May 14, 2023 17:02
@timhoffm timhoffm modified the milestones: v3.7-doc, v3.8.0 May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Documentation topic: mpl_toolkit
Projects
None yet
Milestone
v3.8.0
Development

Successfully merging this pull request may clo 3AB2 se these issues.
3 participants
@anntzer @timhoffm @QuLogic
0