Discourage fontdict #25799
Merged
Discourage fontdict #25799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
approved these changes
May 1, 2023
story645
reviewed
May 1, 2023
ksunden
reviewed
May 1, 2023
Closes matplotlib#10293. `fontdict` is redundant API, but it's not bad enough to justify the user hassle of a deprecation. By discouraging we point the users away from `fontdict` so that the somewhat messy documentation state of `fontdict` is less of a concern. Co-authored-by: hannah <story645@gmail.com>
08ea320 to
8d39a8b
Compare
QuLogic
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10293.
fontdictis redundant API, but it's not bad enough to justify the user hassle of a deprecation. By discouraging we point the users away fromfontdictso that the somewhat messy documentation state offontdictis less of a concern.