MultiCursor: make events connected during __init__ accessible (for later removal) #2579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| """connect events""" | ||
| self.cidmotion = self.canvas.mpl_connect('motion_notify_event', | ||
| self.onmove) | ||
| self.ciddraw = self.canvas.mpl_connect('draw_event', self.clear) |
There was a problem hiding this comment.
Should these have leading _ ? They should not be public facing.
tacaswell
added a commit
that referenced
this pull request
Nov 14, 2013
MultiCursor: make events connected during __init__ accessible (for later removal)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a custom application where I repeatedly clear figures and reinitialize a
MultiCursorobject I need to inherit and override its__init__method (which I now have to maintain withif/elses depending on installed matplotlib version because of changes in upstream, like 349ccec) because I need to disconnect the events again.This would not have been necessary on my end had
MultiCursorbeen aware of the IDs of its connected events. So, I think this might be useful for other people and it would make it possible for me to reuse__init__for future matplotlib versions.(Or maybe I just don't see the easy solution to disconnect these events again without saving their IDs?)