Correctly hide download buttons using CSS #25693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`visibility:hidden; height: 0px` still keeps margins, creating a large amount of whitespace. `display: none` is the correct way to remove an HTML element completely.
rcomer
approved these changes
Apr 16, 2023
|
I'll merge since one review is envough for doc PRs. |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Apr 16, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Apr 16, 2023
ksunden
added a commit
that referenced
this pull request
Apr 17, 2023
…693-on-v3.7.x Backport PR #25693 on branch v3.7.x (Correctly hide download buttons using CSS)
ksunden
added a commit
that referenced
this pull request
Apr 17, 2023
…693-on-v3.7.1-doc Backport PR #25693 on branch v3.7.1-doc (Correctly hide download buttons using CSS)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
visibility:hidden; height: 0pxstill keeps margins, creating a large amount of whitespace.display: noneis the correct way to remove an HTML element completely.before (with margins highlighted):
now:
Also reported upstream: sphinx-gallery/sphinx-gallery#1131