8000 FIX: correctly unset the layout engine in Figure.tight_layout by tacaswell · Pull Request #25624 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

FIX: correctly unset the layout engine in Figure.tight_layout #25624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 5, 2023
Merged

FIX: correctly unset the layout engine in Figure.tight_layout #25624

merged 2 commits into from
Apr 5, 2023

Conversation

tacaswell
Copy link
Member

PR Summary

closes #7805

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • [na] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [na] New plotting related features are documented with examples.

@tacaswell tacaswell added this to the v3.7.2 milestone Apr 5, 2023
rcomer
rcomer reviewed Apr 5, 2023
View reviewed changes
@tacaswell @rcomer
MNT: fix typo in test name
02014be 
Co-authored-by: Ruth Comer <10599679+rcomer@users.noreply.github.com>
@tacaswell
Copy link
Member Author

Thank you @rcomer . I swear I do in fact know how to both type and spell (all evidence to the contrary).

rcomer
rcomer approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member
@rcomer rcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming CI passes...

@rcomer rcomer added the topic: geometry manager LayoutEngine, Constrained layout, Tight layout label Apr 5, 2023
oscargus
oscargus approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member
@oscargus oscargus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyone can merge on green.

@oscargus oscargus merged commit 4c1089b into matplotlib:main Apr 5, 2023
@meeseeksmachine meeseeksmachine mentioned this pull request Apr 5, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Apr 5, 2023
@oscargus @meeseeksmachine
Backport PR matplotlib#25624: FIX: correctly unset the layout engine … < 8000 button type="button" class="ellipsis-expander js-details-target" aria-expanded="false">…
6a82f38 
…in Figure.tight_layout
@tacaswell tacaswell deleted the fix/tightlayout_autolayout branch April 5, 2023 15:22
oscargus added a commit that referenced this pull request Apr 5, 2023
@oscargus
Merge pull request #25626 from meeseeksmachine/auto-backport-of-pr-25…
f451643 
…624-on-v3.7.x

Backport PR #25624 on branch v3.7.x (FIX: correctly unset the layout engine in Figure.tight_layout)
@wch wch mentioned this pull request Jul 10, 2023
Closed
@tacaswell tacaswell mentioned this pull request Jul 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscargus oscargus oscargus approved these changes

@rcomer rcomer rcomer approved these changes

Assignees
No one assigned
Labels
topic: geometry manager LayoutEngine, Constrained layout, Tight layout
Projects
None yet
Milestone
v3.7.2
Development

Successfully merging this pull request may close these issues.

tight layout kwargs have no effect if rc autolayout setting is set (MPL 1.5.3)
3 participants
@tacaswell @oscargus @rcomer
0